Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fbenitez97 patch 1 #175

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fbenitez97 patch 1 #175

wants to merge 3 commits into from

Conversation

Fbenitez97
Copy link
Contributor

Hello!

This pull requests fixes the checkout for Czech Republic. Right now, the state that we are sending is not aligned which what the address form component expects, not allowing the user to continue to the payment step.

You can check the changes in this WS: https://sanzfixcz--carpisa.myvtex.com/checkout/cart/add/?sku=13474&qty=1&seller=1&sc=5

Actual checkout: https://carpisa.myvtex.com/checkout/cart/add/?sku=12597&qty=1&seller=1&sc=5

Phone number to test: 223 223 223

@Fbenitez97
Update Czech Republic regions.
62a5ed1 
Modified the shortCodes so what the address form component expects and what the Checkout UI custom APP sends is aligned.
@Fbenitez97
Update CHANGELOG.md
5e56b3b
@Fbenitez97 Fbenitez97 requested review from wender and polishq November 23, 2022 09:23
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Nov 23, 2022 •
edited by polishq
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@github-actions
Copy link

github-actions bot commented Nov 23, 2022 •
edited
Loading

Fails
🚫

We follow keepachangelog standards.

Please, add a section to your changelog entry. Example:

 ## [Unreleased]

+ ### Fixed
 - Issue with image sizing in the SKU Selector.

You can use one of the following sections:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.
Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 19, PR deletions = 15

Generated by 🚫 dangerJS against 831d76d

@polishq
Copy link
Contributor

polishq commented Dec 13, 2022

@Fbenitez97 Can you rebase your branch please?

Also, please take a look at the documentation and make sure you run the command to compile the checkout scripts as noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wender wender Awaiting requested review from wender

@polishq polishq Awaiting requested review from polishq

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fbenitez97 @polishq